ci(pkg-pr-new): skip preview binary build for fork PRs#292
Merged
RhysSullivan merged 1 commit intoRhysSullivan:mainfrom Apr 18, 2026
Merged
ci(pkg-pr-new): skip preview binary build for fork PRs#292RhysSullivan merged 1 commit intoRhysSullivan:mainfrom
RhysSullivan merged 1 commit intoRhysSullivan:mainfrom
Conversation
Fork PRs don't receive repo secrets under the pull_request trigger, so the R2 upload fails with 'Could not resolve host: .r2.cloudflarestorage.com' because CLOUDFLARE_ACCOUNT_ID is empty. Skip the job for fork PRs; the publish job cascades to skipped via its needs: dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fork PRs currently fail the Build preview binary check in the
Publish (pkg.pr.new)workflow:GitHub's
pull_requesttrigger does not expose repository secrets to workflows running on PRs from forks. That meanssecrets.CLOUDFLARE_ACCOUNT_ID(and the R2 access keys) are empty, so theR2_ENDPOINTURL resolves tohttps://.r2.cloudflarestorage.comand the upload fails.This PR adds
if: github.event.pull_request.head.repo.full_name == github.repositoryto thebuild-preview-binaryjob so it only runs for same-repo PRs. Thepublishjob skips automatically via itsneeds:dependency.Blocked PR
#268 is currently red solely because of this CI issue — its actual changes only touch
apps/*/src/web/shell.tsxand a screenshot.Test plan
build-preview-binary/publishas skipped rather than failed